Maintain a map of pre-built ValidationEngine instances #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
=========================================
Coverage 12.48% 12.49%
- Complexity 32176 32201 +25
=========================================
Files 2203 2203
Lines 672789 672809 +20
Branches 198248 198251 +3
=========================================
+ Hits 83993 84045 +52
+ Misses 559077 559045 -32
Partials 29719 29719 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a map of ValidationEngine instances to ValidationService.
When ValidationService receives a validation request in which the CliContext specifies a baseEngine (a key for the map), the new engine is generated from the pre-existing one, a faster operation than loading all packages.
The only caveat for generation is that the language and locale for the new engine are still set from the CliContext after the engine is copied.