Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Adding a chain to gifts #188

Open
decentration opened this issue Nov 30, 2022 · 4 comments
Open

Adding a chain to gifts #188

decentration opened this issue Nov 30, 2022 · 4 comments

Comments

@decentration
Copy link

This is fabulous dapp, probably the most underated thing in the whole of the ecosystem!

I am configuring this dapp so it takes the kabocha parachain. I have a couple questions.

The connecting node should include the gift pallet in order to be able to issue gift vouchers
Does this require the gift pallet? It seems like a gift pallet is not needed. Please could you clarify.

TypeError: Cannot read properties of undefined (reading 'batchAll')
I'm getting the above error because our parachain does not currently have the utility pallet, do we need the utility pallet in order to use this?

@hamidra
Copy link
Owner

hamidra commented Dec 1, 2022

Thanks.

The connecting node should include the gift pallet in order to be able to issue gift vouchers
Does this require the gift pallet? It seems like a gift pallet is not needed. Please could you clarify.

The app does not need the gift pallet. The mentioned of the gift pallet are from the earlier version of the app, but eventually we noticed there is no need for an extra pallet, and the current balances pallet provides all needed functionality.

TypeError: Cannot read properties of undefined (reading 'batchAll')
I'm getting the above error because our parachain does not currently have the utility pallet, do we need the utility pallet in order to use this?

Yes, it currently uses batch transactions but We should be able to make it configurable if that helps to utilize it in more chains. I'll check to see if we can make it configurable.

@decentration
Copy link
Author

That's great im having a look to see if batchAll is required. Will let you know how i do.

Also when i yarn build i get this error:

Failed to compile.

Failed to minify the code from this file: 

        webpack://./node_modules/@polkadot/types-codec/base/DoNotConstruct.js:28:15 

Read more here: https://cra.link/failed-to-minify

@hamidra
Copy link
Owner

hamidra commented Dec 2, 2022

There were some issues with some of the dependency versions in the yarn.lock, due to the latest changes.
The changes with the corrupt lock file was reverted and the error should be fixed. Pls verify and let me know if you still see the error.

@decentration
Copy link
Author

hey hamid, it now builds : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants