Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for special characters in file name #38

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add support for special characters in file name #38

wants to merge 10 commits into from

Conversation

m1k1o
Copy link

@m1k1o m1k1o commented Dec 26, 2021 •
edited
Loading

Examples what this PR fixes:

  • File name containing ' would result to cropped downloaded name, fixed in 6f26be9.
  • File name containing # would not be downloaded, because its url was not url encoded, fixed in 6a3e40b.
  • File name containing any HTML tag would be rendered, e.g. <b>File</b> or <script>alert('evil');</script>, fixed in a99a51a.
  • Folder name consisting of only 0 would fail, fixed in c963b34.
  • File name consisting of only 0 would fail, fixed in fb5db75.

Other changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with folders names containing dots Folder with dot/point inside are seen as file
1 participant
@m1k1o