Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nohang.conf file format more standard with removing comments via trailing spaces #93

Open
MurzNN opened this issue May 8, 2020 · 1 comment

Comments

@MurzNN
Copy link

MurzNN commented May 8, 2020

At now all strings in nohang.conf file, starting with spaces, are comments, regarding to

    Lines starting with #, tabs and spaces are comments.

This is unusual behavior for most people, and I don't see this format in most of .conf files from other software.

Is this some standardized format? Can you describe why you select this format?

And maybe good idea is make it more standard in new versions via remove info about space-based commends recommenation (mark it obsolete) and force add # to each commented line in example file, but keep current behavior with spaces as comments (for not broke old configs)?

@hakavlad
Copy link
Owner

hakavlad commented May 8, 2020

Is this some standardized format?

No.

Can you describe why you select this format?

I don’t know, it just happened. I do not see this as a big problem, because the format of the comments is described at the beginning of the config.

I plan to release v0.2 with such format, and to change it in v0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants