Upstream merge #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a test for slow servers
Add timeouts around IO calls during authenticate
I have a need for polling the Zookeeper instance with some of the four-letter words. In this PR te following words are implemneted with tests: * srvr * cons * ruok `srvr` get some stats about the server (connections, latencies, leader/follower mode, etc.) `cons` gets detailed information about the individual connections and their sessions `ruok` is actually mostly useless, but specifies whether the server has returned `imok` when prompted with `ruok` I'm not sold on the name of the public API functions, `FLWCons()`, and would happily change them to something better.
Without that patch Conn.Close cannot interrupt Conn.connect. So it's impossible to dispose two goroutines related to a connection, if the connection hasn't been established yet. Signed-off-by: Anton Tiurin <[email protected]>
[Fix] Conn.Close stops all goroutines if we haven't connencted yet
add support for some of the FourLetter words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET. CONTAINS POTENTIALLY BREAKING CHANGES