Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test cases suggestions #141

Open
rmassei opened this issue Oct 14, 2024 · 8 comments · Fixed by #142
Open

New test cases suggestions #141

rmassei opened this issue Oct 14, 2024 · 8 comments · Fixed by #142

Comments

@rmassei
Copy link

rmassei commented Oct 14, 2024

Hi!
I was wondering if the following test cases might be of interest:

  • Reading/adding metadata using with bioio or tifffile
  • Including a couple of test cases with the library mahotas
  • Convert ROIs coordinates or metadata to data structures that can be used by the library ezomero for import in OMERO (i.e convert tabular files to dictionary/lists/tupples). Mostly data wrangling with pandas.
@tischi
Copy link
Collaborator

tischi commented Oct 15, 2024

+1 for bioio

@rmassei
Copy link
Author

rmassei commented Oct 15, 2024

ome-types is another options, since I found myself to often use it to compile ome.xml with standardize metadata

@rmassei
Copy link
Author

rmassei commented Oct 17, 2024

PR in #142

@haesleinhuepf
Copy link
Owner

Love it, thanks for the proposals @rmassei ! Regarding mahotas and omero: I'd say these test-cases would be interesting, if you formulare the prompts in a way, that mahotas / omero are not mentioned as library. So far, our test-cases typically formulate a problem, and do not ask for specific libraries (with the exception of numpy). In my opinion (others may have other opinions), we should not have test-cases like "Register the images using ITK", but better "register the images" and with this, give the LLM the freedom to also use libraries, we did not think of. You see in this figure of the current paper, that the LLMs chose to use openCV (cv2) in many cases, and we did not think of this.

Hence, do you know any use-cases that can be solved with mahotas, which were not on our list yet?

@rmassei
Copy link
Author

rmassei commented Oct 18, 2024

Thanks for the explanation @haesleinhuepf!
I did not add mahotas cases in the PR since, after looking at the existing cases, inspiration did not knock at my door and I could not find anything new to add, at least as a snippet.
I will check the documentation and see if there are some tasks which can be interesting to solve with mahotas, but I will then probably open another PR.

@haesleinhuepf
Copy link
Owner

I dived into mahotas earlier, and found the seeded watershed implementation nice; much easier to use than the one from scikit-image. Maybe that's an inspiration. And if not that's ok too. With the use-cases you sent, you will already be the 2nd or 3rd most-contributing contributor ;-)

@tischi
Copy link
Collaborator

tischi commented Oct 18, 2024

I generally agree on not asking about solutions implemented in specific packages.

However, don't we implicitly only allow for specific packages because our testing environment does not have everything? I forgot: Are the available libraries something that we communicate to the LLM for writing the code?

@haesleinhuepf
Copy link
Owner

The readme explains how to deal with missing dependencies (we add them to the requirements.txt) and has a link to a notebook for detecting missing stuff:
https://github.com/haesleinhuepf/human-eval-bia/blob/main/demo/detect_missing_requirements.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants