Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixing Test Cases] Allow 0 in label image test cases #134

Conversation

ian-coccimiglio
Copy link
Contributor

This PR contains:

  • a new test-case for the benchmark
    • I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark
  • new dependencies in requirements.txt
    • The environment.yml file was updated using the command conda env export > environment.yml
  • new generator-functions allowing to sample from other LLMs
  • new samples (sample_....jsonl files)
  • new benchmarking results (..._results.jsonl files)
  • documentation update
  • bug fixes

Related github issue (if relevant): closes #130

Short description:

  • Test cases involving label images will now accept 0 as a valid label if the LLM solution includes it.

How do you think will this influence the benchmark results?

  • Broadly increases the scoring for these test_cases (in my view, nearer to expectation)

Why do you think it makes sense to merge this PR?

Copy link
Owner

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @ian-coccimiglio and thanks for working on this!

While I agree that in some cases label 0 should be counted and/or measured, I don't think that this is the case in third test-case "workflow_batch_process_folder_count_labels" (see comment below).

I would merge two of the three cases if nobody objects.

@haesleinhuepf haesleinhuepf changed the base branch from main to development-collecting-new-test-cases November 21, 2024 13:09
@haesleinhuepf
Copy link
Owner

Thanks for working on this @ian-coccimiglio !

@haesleinhuepf haesleinhuepf merged commit fa65fe7 into haesleinhuepf:development-collecting-new-test-cases Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fixing Test Cases] Label Images - When should 0 be considered a label?
2 participants