Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mean_std_column to accept both pandas and numpy stdev #126

Conversation

ian-coccimiglio
Copy link
Contributor

This PR contains:

  • a new test-case for the benchmark
    • I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark
  • new dependencies in requirements.txt
    • The environment.yml file was updated using the command conda env export > environment.yml
  • new generator-functions allowing to sample from other LLMs
  • new samples (sample_....jsonl files)
  • new benchmarking results (..._results.jsonl files)
  • documentation update
  • bug fixes

Related github issue (if relevant): closes #124

Short description:

  • Allows both the unbiased and unbiased standard deviation allowance

How do you think will this influence the benchmark results?

  • Fixes many missed positive results for test_case 'mean_std_column.ipynb'

Why do you think it makes sense to merge this PR?

  • Makes a more accurate benchmark according to the stated goal and prompt.

Copy link
Owner

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reran the notebook. Otherwise it LGTM

@haesleinhuepf haesleinhuepf changed the base branch from main to development-collecting-new-test-cases September 13, 2024 08:43
@haesleinhuepf haesleinhuepf merged commit 4b1cc18 into haesleinhuepf:development-collecting-new-test-cases Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fixing Test-Cases] Pandas/Numpy use different stdev estimators (mean_std_column)
2 participants