Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creditor simple stats #226

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

jssmk
Copy link
Member

@jssmk jssmk commented Apr 22, 2017

Transaction browse tool for staff.

Copy link
Member

@rambo rambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests ?

@@ -37,6 +37,7 @@
# Your stuff: custom urls includes go here
url(r'^members/', include('members.urls')),
url(r'^velkoja/', include('velkoja.urls')),
url(r'^creditor/', include('creditor.urls')),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be under /admin/ -urlspace somehow ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution now in f7a8e7c. Though, might not be the ideal way to handle this.

{% endblock %}


{% block title %} {{ site_title|default:_('Django site admin') }}{% endblock %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs proper title

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in 82bf0ac

from . import views

urlpatterns = [
url(r'^transaction_table/$', permission_required('is_staff')(views.TransactionYearView.as_view()), name="table_y"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This decorator redirects to nonexistent URL for login, probably a missing configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login_url set in e059375

@jssmk
Copy link
Member Author

jssmk commented Sep 4, 2017

Some tests now included. General cleanup.

@rambo
Copy link
Member

rambo commented Jan 31, 2019

Rebase to master, make sure tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants