Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Update wins.js so the Wins overlay uses icon-github.svg #7727

Open
1 of 5 tasks
roslynwythe opened this issue Nov 18, 2024 · 2 comments
Open
1 of 5 tasks

ER: Update wins.js so the Wins overlay uses icon-github.svg #7727

roslynwythe opened this issue Nov 18, 2024 · 2 comments
Labels
Complexity: Large ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Wins Page https://www.hackforla.org/wins/ ready for product role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Nov 18, 2024

Emergent Requirement - Problem

The wins overlay (which appears when the user expands a wins card using "See More" link) contains a reference to /assets/images/wins-page/icon-github-small.svg, and we would like to replace that reference with a reference to _includes/svg/icon-github.svg.

Issue you discovered this emergent requirement in

Date discovered

12/18/2024

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@roslynwythe

What happens if this is not addressed

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 0.25pt Can be done in 0.5 to 1.5 hours ER Emergent Request role missing Complexity: Missing labels Nov 18, 2024

This comment was marked as outdated.

@roslynwythe roslynwythe added Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Issue Making: Level 2 Make issue(s) from an ER or Epic and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 0.25pt Can be done in 0.5 to 1.5 hours role missing Complexity: Missing labels Nov 18, 2024
@roslynwythe
Copy link
Member Author

@ExperimentsInHonesty I want to mention that while this issue relates to the GitHub icon, I believe a similar situation exists with the LinkedIn icon. I'm not sure if we should address the LinkedIn icon in this ER or a different one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Wins Page https://www.hackforla.org/wins/ ready for product role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Projects
Status: New Issue Approval
Development

No branches or pull requests

1 participant