Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial breaks if user closes verification or sticker ordering before completion #790

Open
polytroper opened this issue Nov 16, 2024 · 0 comments
Assignees

Comments

@polytroper
Copy link
Collaborator

Right now if the user closes the verification or sticker order form without completing them, the tutorial will break. If they reopen the magic link from slack, they get stuck in a loop on the ts-signpost step. If they navigate to any other page, it just takes them back to the signpost and shows the final tutorial step. I just got an email from a user in this situation and tested it myself. Instead of setting the next tutorial step on button click, I think we need to set that step when the user navigates to the page and the person record has academy_completed == true

Make sure to independently test the cases where the user closes during verification and when they close during the order flow step (not just the address, but the actual order flow!) because these are subtly different. Also we need to test the case where they close on one browser and reopen on another, which currently sends them back to the start of the tutorial. This is correct but we should make sure it stays working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants