Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/spark 3.5 #435

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Feature/spark 3.5 #435

merged 4 commits into from
Mar 12, 2024

Conversation

alfonsorr
Copy link
Member

@alfonsorr alfonsorr commented Mar 8, 2024 •
edited by eruizalo
Loading

Spark 3.5.1 was added to compile against.

Description

Spark 3.5, what else to say!!!

Related Issues and dependencies

Partially resolves #394

How Has This Been Tested?

CI updated to check that everything works as expected.

  • This pull request contains the appropriate tests?:
    • YES
    • Something relevant to mention

@alfonsorr alfonsorr requested a review from a team as a code owner March 8, 2024 22:56
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 spark_3.4 PR changes to spark 3.4 labels Mar 8, 2024
@alfonsorr alfonsorr force-pushed the feature/spark_3.5 branch from dd9cd2c to a14ff7e Compare March 8, 2024 23:00
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

:octocat: This is an auto-generated comment created by:

  • Date : 2024-03-08 23:55:36 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 8210403506
  • Commit : 9eca4f6 Doc error due to a new alternative version of the method
Actor Triggering actor Sender
alfonsorr
alfonsorr 		alfonsorr
alfonsorr 		alfonsorr
alfonsorr
Triggered by:

Test summary report 📊

Spark version testing
3.0.0 684 passed, 2 skipped
3.0.1 684 passed, 2 skipped
3.0.2 684 passed, 2 skipped
3.0 684 passed, 2 skipped
3.1.0 712 passed, 2 skipped
3.1.1 712 passed, 2 skipped
3.1.2 712 passed, 2 skipped
3.1 712 passed, 2 skipped
3.2.0 716 passed, 2 skipped
3.2.1 716 passed, 2 skipped
3.2.2 716 passed, 2 skipped
3.2 716 passed, 2 skipped
3.3.0 716 passed, 2 skipped
3.3.1 716 passed, 2 skipped
3.3.2 716 passed, 2 skipped
3.3.3 716 passed, 2 skipped
3.3 716 passed, 2 skipped
3.4.0 716 passed, 2 skipped
3.4.1 716 passed, 2 skipped
3.4 716 passed, 2 skipped
3.5.0 716 passed, 2 skipped
3.5 716 passed, 2 skipped

@alfonsorr alfonsorr added the spark_3.5 PR changes to spark 3.5 label Mar 8, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (be8f352) to head (9eca4f6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          62       62           
  Lines        1255     1255           
  Branches       37       37           
=======================================
  Hits         1226     1226           
  Misses         29       29
Flag Coverage Δ
spark-3.0.x 96.71% <ø> (ø)
spark-3.1.x 97.45% <ø> (ø)
spark-3.2.x 97.66% <ø> (ø)
spark-3.3.x 97.66% <ø> (ø)
spark-3.4.x 97.66% <ø> (ø)
spark-3.5.x 97.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <ø> (ø)
....3_3.4_3.5/scala/doric/syntax/ArrayColumns3x.scala 100.00% <ø> (ø)
...3_3.4_3.5/scala/doric/syntax/CommonColumns3x.scala 100.00% <ø> (ø)
....2_3.3_3.4_3.5/scala/doric/syntax/DStructs3x.scala 100.00% <ø> (ø)
..._3.3_3.4_3.5/scala/doric/syntax/MapColumns3x.scala 100.00% <ø> (ø)
....3_3.4_3.5/scala/doric/syntax/StringColumn3x.scala 100.00% <ø> (ø)
...doric/RelationalGroupedDatasetDoricInterface.scala 100.00% <ø> (ø)
..._3.5/scala/doric/syntax/AggregationColumns31.scala 100.00% <ø> (ø)
..._3.4_3.5/scala/doric/syntax/BooleanColumns31.scala 100.00% <ø> (ø)
..._3.4_3.5/scala/doric/syntax/NumericColumns31.scala 100.00% <ø> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8f352...9eca4f6. Read the comment docs.

@github-actions github-actions bot added the spark_2.4 PR changes to spark 2.4 label Mar 8, 2024
@eruizalo eruizalo removed the spark_2.4 PR changes to spark 2.4 label Mar 12, 2024
@eruizalo eruizalo mentioned this pull request Mar 12, 2024
Open
@eruizalo eruizalo merged commit fee55fc into hablapps:main Mar 12, 2024
54 checks passed
@eruizalo eruizalo mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eruizalo eruizalo eruizalo approved these changes

Assignees
No one assigned
Labels
CI/CD Continuous integration and continuous delivery dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 spark_3.4 PR changes to spark 3.4 spark_3.5 PR changes to spark 3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Spark version 3.5.0
2 participants
@alfonsorr @eruizalo