Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] #105 improve raiseError with location #283

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

eruizalo
Copy link
Collaborator

Description

raiseError function could be improved adding the column location on the error message

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@github-actions github-actions bot added spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Sep 30, 2022
@eruizalo eruizalo force-pushed the feat/105-improve-raiseError branch from 3769efe to 0cfcbf2 Compare October 1, 2022 12:36
@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #283 (38ab4c3) into main (338b337) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   97.34%   97.35%           
=======================================
  Files          58       58           
  Lines        1129     1131    +2     
  Branches       21       13    -8     
=======================================
+ Hits         1099     1101    +2     
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.86% <ø> (ø)
spark-3.0.x 96.65% <ø> (ø)
spark-3.1.x 97.46% <100.00%> (+<0.01%) ⬆️
spark-3.2.x 97.46% <100.00%> (+<0.01%) ⬆️
spark-3.3.x 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...1_3.2_3.3/scala/doric/syntax/StringColumns31.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338b337...38ab4c3. Read the comment docs.

@eruizalo eruizalo force-pushed the feat/105-improve-raiseError branch from 0cfcbf2 to 5c9100a Compare October 1, 2022 12:57
@eruizalo eruizalo force-pushed the feat/105-improve-raiseError branch from 08af017 to 38ab4c3 Compare October 3, 2022 11:08
@eruizalo eruizalo marked this pull request as ready for review October 3, 2022 11:51
@eruizalo eruizalo requested a review from a team as a code owner October 3, 2022 11:51
@eruizalo eruizalo merged commit 695f3dc into hablapps:main Oct 3, 2022
@eruizalo eruizalo deleted the feat/105-improve-raiseError branch October 3, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve raiseError function (more "doricable")
2 participants