Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Era should not have a content, only a title #51

Open
DegrangeM opened this issue Apr 15, 2021 · 1 comment
Open

Era should not have a content, only a title #51

DegrangeM opened this issue Apr 15, 2021 · 1 comment

Comments

@DegrangeM
Copy link

https://h5p.org/node/1143564

@DegrangeM
Copy link
Author

I might be wrong, the link https://timeline.knightlab.com/docs/json-format.html#json-text is about the version 3 of the timeline and h5p use the version 2. The text attribute can be find here in the v2 : https://github.com/NUKnightLab/TimelineJS#json
but strangely it is not here https://github.com/NUKnightLab/TimelineJS#jsonp- making me think that they have probably fixed it in the jsonp example but not in the json example.

But I checked very quickly the source code of the v2 and the text value seems used in code. But I didn't check if it is really displayed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant