Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot name is static at launchSettings.json #21

Open
angie4u opened this issue Jan 3, 2020 · 1 comment
Open

Bot name is static at launchSettings.json #21

angie4u opened this issue Jan 3, 2020 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@angie4u
Copy link
Collaborator

angie4u commented Jan 3, 2020

"KeyVaultName": "mygeodistributedbot",

Currently, bot name set to a static value which is "mygeodistributedbot".
It can cause an error for the user who wants to debug locally.
It will be better to set empty or change dynamically while a user deployment a bot.

@h2floh h2floh added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 6, 2020
@h2floh
Copy link
Owner

h2floh commented Jan 6, 2020

I suggest, to delete the KeyVaultName env setting in launchSettings.json and create a documentation on how to configure the Bot for local debugging.

.ConfigurationFromKeyVault()

.ConfigurationFromKeyVault(keyVaultName: "<yourbotname>", azureConnectionString: "RunAs=App;AppId=<AppId>;TenantId=<TenantId>;AppKey=<AppKey>")

This line has to be modified with a service principal which has GET and LIST rights on the central KeyVault. This SP has to be generated first and rights granted (seperate script).

However the region env variable still needs to be in place, based on which regions you deployed and which one you want to test.

At least we need some documentation for local debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants