Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

소셜 로그인 리팩토링 #24

Open
5 of 8 tasks
kim1387 opened this issue Apr 14, 2022 · 0 comments
Open
5 of 8 tasks

소셜 로그인 리팩토링 #24

kim1387 opened this issue Apr 14, 2022 · 0 comments
Assignees

Comments

@kim1387
Copy link
Member

kim1387 commented Apr 14, 2022

소셜 로그인 리팩토링이 좀 필요할 것 같습니다.

  • secret key 분리
  • test code 작성
  • srp 지키도록 1 책임당 1개의 service로 분리하기
  • entity 검증 로직 추가하기
  • controller에서 영속성 계층 접근하는 코드 리팩토링하기
  • 토큰 없이도 swagger 접근 가능하도록 하기
  • redis로 refresh 토큰 관리
  • http only 옵션 찾아보기
@kim1387 kim1387 self-assigned this Apr 14, 2022
@kim1387 kim1387 added enhancement New feature or request and removed enhancement New feature or request labels Apr 14, 2022
@kim1387 kim1387 linked a pull request Apr 30, 2022 that will close this issue
@0BVer 0BVer modified the milestone: sprint3 May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants