Removed all forceOp functionality #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in violation of SpigotMC guidelines.
Chew
changed the title
|
Indeed! |
KaspianDev
suggested changes
Jan 30, 2022
| @@ -40,7 +39,7 @@ public boolean onCommand(final CommandSender sender, Command command, String lab | |||
| try { | |||
| Player plr = sender instanceof Player ? (Player) sender : null; | |||
| String cmd = args.length == 0 ? "help" : args[0].toLowerCase(); | |||
| if (!sender.hasPermission("spigotlib.command." + cmd) && !(allowAllPermsForAuthor && plr != null && plr.getUniqueId().equals(author))) { | |||
| if (!sender.hasPermission("spigotlib.command." + cmd) && !(plr != null && plr.getUniqueId().equals(author))) { | |||
There was a problem hiding this comment.
no, u timetraveled, saw me comment this in the future then was like bro wish id thought of that, went back in time just to comment it first. I see through your tricks >:C
PeachesMLG
reviewed
Jan 30, 2022
| @@ -40,7 +39,7 @@ public boolean onCommand(final CommandSender sender, Command command, String lab | |||
| try { | |||
| Player plr = sender instanceof Player ? (Player) sender : null; | |||
| String cmd = args.length == 0 ? "help" : args[0].toLowerCase(); | |||
| if (!sender.hasPermission("spigotlib.command." + cmd) && !(allowAllPermsForAuthor && plr != null && plr.getUniqueId().equals(author))) { | |||
| if (!sender.hasPermission("spigotlib.command." + cmd) && !(plr != null && plr.getUniqueId().equals(author))) { | |||
There was a problem hiding this comment.
you just removed the option to disable it here, it will still give you access if you are the author dum dum.
p.s. ik this is dead but i saw this and thought it was funny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in violation of SpigotMC guidelines.
I'm not spigot staff I just wanna help a homie out
Fixes #10