-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow for IUPAC codes in GetCanonicalMotif()
#239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the reverse complement issue, whether or not this should be done depends on how it is used or intended to be used. I see no uses of GetCanonicalMotif or ReverseComplement in TRTools, so I cannot evaluate that and instead leave that choice to you.
Thanks for the suggestions! I tried my best to implement them in c1f78ee. Does that look better?
In this case, I think |
This looks good! (Though I haven't personally checked your complement table is fully correct :) ) |
great, thanks for the review, Jonathan! |
It turns out that this PR actually isn't helpful for fixing the issue in EnsembleTR anyway, so I'm just going to close it for now. Feel free to reopen if it's ever needed! In the meantime, you can follow gymrek-lab/EnsembleTR#32 for the next chapter of this story |
partially addresses #238
This will allow TRTools's
GetCanonicalMotif()
to work for sequences that have IUPAC codes. However, this will not entirely solve the problem described in #238, since any function that callsGetCanonicalMotif()
will now have to handle the IUPAC codes somehow.