Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 3 Review #5

Open
yang127 opened this issue Dec 12, 2016 · 0 comments
Open

Project 3 Review #5

yang127 opened this issue Dec 12, 2016 · 0 comments

Comments

@yang127
Copy link

yang127 commented Dec 12, 2016

Hi Yatao,

I have no problem execute all your notebook files in datanotebook.org, I really like your groups topic as it would be really helpful for those who are going to move to California and pursue a career there.

I see you guys used trifacta to do the data cleaning though you have a extremely large dataset, which is the same case with our group. I'm really impressed that you divide those files into 35 smaller files to clean and fix it then combine it together. I can see this is very time consuming. Instead, we use pandas dataframe to do the similar work, which may be easier and save a little time when you do the analysis.

I really like your analysis part, where you pick 3 cities as focus for analysis and you analyze the property type so you found out that Santa Clara is most suitable to live. In addition, I think it's nice to include the comparison part of land-value versus time. Also your logic in creating star-schema is really clear and neat.

Just some suggestions as I think there are some repetitive part in your two notebook files, maybe you can delete the similar part.

Overall, good work!

Thanks,
Yi Yang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant