Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the error in the computation of cumulative percentage #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

askawron
Copy link
Contributor

Solves issue #21

@gvelasq
Copy link
Owner

gvelasq commented Apr 27, 2024

The syntax you used in your comment above would not automatically close the issue if this PR were merged. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@gvelasq
Copy link
Owner

gvelasq commented Apr 27, 2024

Closes #21

Copy link
Owner

@gvelasq gvelasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update NEWS?

df_to_return <- x
if (ncol(x) == 4 & colnames(x)[2] == "Freq.") {
total_freq <- formatC(sum(x[, 2]), digits = 0L, format = "f")

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These spaces do not seem necessary to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants