Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated use of .data in tidyselect expressions #15

Open
fkohrt opened this issue Mar 9, 2023 · 3 comments · May be fixed by #26
Open

Deprecated use of .data in tidyselect expressions #15

fkohrt opened this issue Mar 9, 2023 · 3 comments · May be fixed by #26
Labels
help wanted ❤️ we'd love your help! upkeep maintenance, infrastructure, and similar

Comments

@fkohrt
Copy link

fkohrt commented Mar 9, 2023 

withr::with_options(
    list(lifecycle_verbosity = "error"),
    tidytab::tab(letters[23:26])
)

gives

Error:
! Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `all_of(var)` (or `any_of(var)`) instead of `.data[[var]]`
@gvelasq
Copy link
Owner

gvelasq commented Mar 12, 2023

Thank you for pointing this out. Would you be interested in filing a PR? I believe the way I initially implemented tidyselect helpers in #3 may no longer be best practice.

@fkohrt
Copy link
Author

fkohrt commented Mar 12, 2023

Would you be interested in filing a PR?

Not right now I'm afraid, too many other things on the plate...

@gvelasq
Copy link
Owner

gvelasq commented Apr 14, 2024

Related: #11

@gvelasq gvelasq added upkeep maintenance, infrastructure, and similar help wanted ❤️ we'd love your help! labels Apr 17, 2024
@ramongss ramongss linked a pull request May 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted ❤️ we'd love your help! upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated .data[[var]] with tidyselect::all_of(var) ramongss/tidytab
2 participants
@fkohrt @gvelasq