Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Scale per-file comment limit proportionally to diff content #284

Open
raphaelcastaneda opened this issue Jun 14, 2018 · 0 comments
Open

Feature request: Scale per-file comment limit proportionally to diff content #284

raphaelcastaneda opened this issue Jun 14, 2018 · 0 comments
Assignees
@raphaelcastaneda
Labels
enhancement

Comments

@raphaelcastaneda
Copy link
Collaborator

raphaelcastaneda commented Jun 14, 2018 •
edited
Loading

Currently, there is a limit of max_comments / 5 for comments in any one file.
https://github.com/guykisel/inline-plz/blob/master/inlineplz/interfaces/github.py#L183-L187

If a PR has a ton of change in one file, and not so much in others, it would be nice to allow more comments in that heavily-changed file.

Proposal: calculate the per-file comment limit as: (lines changed in this file / total lines in the diff) * max_comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelcastaneda raphaelcastaneda

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raphaelcastaneda