whether to consider pnpm compatibility?

[AnaniZhu]

this code get .bin folder failed when use pnpm

[najens]

I was able to get this library to work with pnpm by updating the resolve path to the tsc executable.

Looking into a cleaner solution that can be added as a pull request.

[FFdhorkin]

tsc-files 1.1.4 does not appear to currently work with pnpm.

In node_modules/.bin/tsc-files, it has

if [ -z "$NODE_PATH" ]; then
  export NODE_PATH="/my/project/path/node_modules/.pnpm/[email protected][email protected]/node_modules/tsc-files/node_modules:/my/project/path/node_modules/.pnpm/[email protected][email protected]/node_modules:/my/project/path/node_modules/.pnpm/node_modules"
else
  export NODE_PATH="/my/project/path/node_modules/.pnpm/[email protected][email protected]/node_modules/tsc-files/node_modules:/my/project/path/node_modules/.pnpm/[email protected][email protected]/node_modules:/my/project/path/node_modules/.pnpm/node_modules:$NODE_PATH"
fi

At the end of node_modules/tsc-files/cli.js, it has

const { status } = result = spawnSync(
  // See: https://github.com/gustavopch/tsc-files/issues/44#issuecomment-1250783206
  process.versions.pnp
    ? 'tsc'
    : resolveFromModule(
      'typescript',
      `../node_modules/.bin/tsc${process.platform === 'win32' ? '.cmd' : ''}`,
    ),
  ['-p', tmpTsconfigPath, ...remainingArgsToForward],
  { stdio: 'inherit' },
)

pnp resolves to undefined, so it goes to the false case of the ternary. Then it resolves the path to /my/repo/path/node_modules/.pnpm/[email protected]/node_modules/node_modules/.bin/tsc... which doesn't exist

incidentally, you have to go up several levels to get to something that does exist: /my/repo/path/node_modules/.pnpm/[email protected]/node_modules/ and the only contents of that folder are a subfolder called typescript. There is no bin there!

This needs to resolve to /my/repo/path/node_modules/.pnpm/[email protected]/node_modules/typescript/bin/tsc to work with pnpm.

This seems to work with pnpm:

const { status } = result = spawnSync(
  // See: https://github.com/gustavopch/tsc-files/issues/44#issuecomment-1250783206
  process.versions.pnp
    ? 'tsc'
    : resolveFromRoot(
      `node_modules/.bin/tsc${process.platform === 'win32' ? '.cmd' : ''}`,
    ),
  ['-p', tmpTsconfigPath, ...remainingArgsToForward],
  { stdio: 'inherit' },
)

[jonasgeiler]

My fork tried to implement this: https://github.com/skayo/tsc-files
It works for my PNPM projects, but I only tested it on Linux so there might still be problems.
Not sure if I should do a PR here, but for now I'll release it as my own package (@jonasgeiler/tsc-files).