Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move any posit, viz, etc. code out of index.html -- maximize separation #39

Open
gussmith23 opened this issue May 17, 2019 · 2 comments
Labels

Comments

@gussmith23
Copy link
Owner

I don't think we should be doing any logic other than e.g. setting the highest-level parameters (maybe max n and es?) in index. Ideally, we would just:

  1. Define the bare minimum of parameters
  2. Create the SVG on the page (could be done statically in HTML)
  3. Call a createViz() function, passing in max n, max es, the SVG, and other parameters.
@gussmith23 gussmith23 added the bug Something isn't working label May 17, 2019
@gussmith23
Copy link
Owner Author

I think there is a lot of separation already, but we could potentially do more. For example, sliders could move into the viz.js file (esp. if we're going to put them inside the circle, which probably means putting them in the SVG).

@gussmith23
Copy link
Owner Author

I think the goal would be to keep any calls to update within viz.js

@mara-kr mara-kr added Refactor and removed bug Something isn't working labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants