Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working example #7

Open
ShaMan123 opened this issue Jan 6, 2022 · 3 comments
Open

Working example #7

ShaMan123 opened this issue Jan 6, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@ShaMan123
Copy link

ShaMan123 commented Jan 6, 2022

I'd love to see a working example of the features supported by this addon and an explanation of the goal of it
I think these links can do good in the description and as a skeleton for an example
https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit
https://developer.mozilla.org/en-US/docs/Web/CSS/object-position

@guesant guesant added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 6, 2022
@guesant
Copy link
Owner

guesant commented Jan 6, 2022

Hello @ShaMan123. I've made tree examples just for test if the things works, you can see then here: https://guesant.github.io/fabricjs-object-fit/examples/. But it has no style and I feel that the VuePress page container is too small.

Now I can think more about cool styles, more examples w/ the code and explanations.


[...] and an explanation of the goal of it

Do you mean some real use cases of cover, contain etc ?

@ShaMan123
Copy link
Author

ShaMan123 commented Jan 8, 2022

that would be clear and straight to the point
think about a dev that stumbles upon this repo and wants to understand what it does in a few lines

@ShaMan123
Copy link
Author

The test page is great

@guesant guesant added this to the v1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants