WebRTCBin.createAnswer() callback not called sporadically (promise garbage collected)

[jw-meelogic]

Looks like the promise which is used inside the method sometimes gets garbage collected before callback is called.

reproducible with:

webRtcBin.createAnswer(answer -> {
   System.out.println("ANSWER");
});
System.gc();

[neilcsmith-net]

Yes, think I can see where the problem lies there. Most of the webrrc code was donated by someone who has not contributed for some time. Few options to consider to fix. Do you want to take it on?

[jw-meelogic]

See pull request

[neilcsmith-net]

See pull request

Thanks. That might be the simplest way to fix this, although I have a slight concern on that implementation.

As and when we know whether there will be any further releases of this library, I'll review and/or merge.

[jw-meelogic]

Extended the pull request with data channel support.