Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example camonet actions added #32

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

senshi-x
Copy link
Contributor

@senshi-x senshi-x commented Aug 4, 2023

Added the desired "fix camonet" action for players. Added 3 example ways (vanilla+ ACE Progress Bar, vanilla holdaction and ACE interact+progressbar) of doing it so you can compare and pick one.
Personally, I'd vote for either vanilla menu or ACE interact, not vanilla holdaction, because we don't use it anywhere else in this mission.

Also increased default damage of camonets to make them less powerful shields.

Fixes #29
Partly fixes #30 -- only camonet interactions

@senshi-x senshi-x requested a review from b-mayr-1984 August 4, 2023 11:47
@b-mayr-1984
Copy link
Member

Added 3 example ways (vanilla+ ACE Progress Bar, vanilla holdaction and ACE interact+progressbar) of doing it so you can compare and pick one. Personally, I'd vote for either vanilla menu or ACE interact, not vanilla holdaction, because we don't use it anywhere else in this mission.

Thx for the fix and providing a choice. 🙂

Here is my reasoning:

  • The reason why I initially prefered Vanilla over ACE is, that the possibility to repair the net presents itself automatically without the user needing to check for it (e.g. by pressing ACE interact and then needing to find the interact point on such a large object; I personally sometimes struggle to find this point e.g. on large grad-trenches).

    • You just look at a broken net and then you see that you can repair it (if the action is at the top of the action list). This would be one less feature that needs explicit mentioning in the documentation.
  • The reason why I prefer holdaction over the standard action is the time penalty for the action. It should take a while to put a camo net back up.

    • RHS towing is using a holdaction. So it is not new to the mission.

@b-mayr-1984
Copy link
Member

@senshi-x never mind my comments above.

I just noticed that your option with Vanilla action + ACE progress bar is exactly doing the job. 🙂👍
image
image

I will just make slight modifications to strings and distances and then merge the PR. Thanks. ❤️

Copy link
Member

@b-mayr-1984 b-mayr-1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just make slight modifications to strings and distances and then merge the PR.

+ reducing repair radius to 12m
@b-mayr-1984 b-mayr-1984 merged commit 5c09a1b into gruppe-adler:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix restock area around containers Camo Nets act as powerful shields
2 participants