Shooter #4
Closed
Shooter #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penguin212
commented
Jan 19, 2024
| rotationEncoder.setPosition(0); | ||
| } | ||
|
|
||
| if(currentState == FIRING && (shooterSensor.get() < tolerance)){ //when there is no note |
There was a problem hiding this comment.
The note may not be visible but still in the shooter, you will most likely need to add a delay (< .5s) to ensure the note leaves the shooter before you stop powering the flywheels and feed belts.
|
|
||
| //change later | ||
| int IDNUMBER = 10; //so I remember to change them later | ||
| double speed = 0.1; |
There was a problem hiding this comment.
if this is a constant, capitalize it, otherwise move it to a different part of the variable declarations
penguin212
commented
Jan 21, 2024
| } | ||
|
|
||
| //once driver presses button to shoot (should test with a solo button after shooter state called) | ||
| private void shootNote(){ |
There was a problem hiding this comment.
This should be public so that code outside of this class can access it
GitHub checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.