Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression handling uses wrong error codes #1428

Open
jhump opened this issue May 30, 2024 · 1 comment
Open

Compression handling uses wrong error codes #1428

jhump opened this issue May 30, 2024 · 1 comment
Labels

Comments

@jhump
Copy link
Member

jhump commented May 30, 2024

According to the gRPC docs for compression, when a server sends a response using an unrecognized/unsupported encoding the client MUST report the error with an internal error code. (See bullet 5 in the test cases section of that doc.)

Similarly, when a server sends a message where the envelope has the “compressed” bit set, but there is no encoding for the stream (or the encoding is “identity”), the recipient MUST fail with an internal error code.

The client in this package returns an unknown error in both of these situations instead of internal.

@sampajano sampajano added the spec label Jun 4, 2024
@sampajano
Copy link
Collaborator

@jhump Thanks a lot for reporting! Will take a look soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants