From 1fb6a614c4945fcb5b2f52a5ea9b6c893fdbd0e8 Mon Sep 17 00:00:00 2001 From: Jason Schleifer Date: Tue, 5 Nov 2024 07:17:35 +1300 Subject: [PATCH 1/4] removed dynamicPrompt because it breaks urls. --- nodes/agent/BaseAgent.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/nodes/agent/BaseAgent.py b/nodes/agent/BaseAgent.py index 63dd938..195308b 100644 --- a/nodes/agent/BaseAgent.py +++ b/nodes/agent/BaseAgent.py @@ -64,7 +64,7 @@ def INPUT_TYPES(s): "STRING", { "forceInput": True, - "dynamicPrompts": True, + # "dynamicPrompts": True, "tooltip": "Additional text be appended to the STRING with a newline character.", }, ), @@ -72,7 +72,7 @@ def INPUT_TYPES(s): "STRING", { "multiline": True, - "dynamicPrompts": True, + # "dynamicPrompts": True, "tooltip": "The prompt text.", }, ), @@ -148,7 +148,8 @@ def run(self, **kwargs): tools = kwargs.get("tools", []) rulesets = kwargs.get("rulesets", []) input_string = kwargs.get("input_string", None) - + print(f"STRING: {STRING=}") + print(f"input_string: {input_string=}") # Defaults.drivers_config = DriversConfig() create_dict = {} # Configuration From a76dc53964d768e8e04905f2dd7e76d5bf6ed440 Mon Sep 17 00:00:00 2001 From: Jason Schleifer Date: Tue, 5 Nov 2024 07:19:03 +1300 Subject: [PATCH 2/4] info on dynamicprompt fix --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index b4fa586..bc14b8f 100644 --- a/README.md +++ b/README.md @@ -104,6 +104,9 @@ You can previous and download more examples [here](examples/README.md). ## Recent Changelog +### Nov 5, 2024 +* Fixed bug where urls were dropping any text after the `:`. Example: "What is https://griptape.ai" was being converted to "What is https:". This is due to the `dynamicprompt` functionality of ComfyUI, so I've disabled that. + ### Nov 4, 2024 * Fixed bug where OPENAI_API_KEY was still required, and was causing some install issues. * Added video to README with how to manage api keys. From 37a6313cc4f039652ff99246b00520539bebf5e2 Mon Sep 17 00:00:00 2001 From: Jason Schleifer Date: Tue, 5 Nov 2024 07:25:02 +1300 Subject: [PATCH 3/4] update version information --- js/versions.js | 11 +++++++++-- pyproject.toml | 4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/js/versions.js b/js/versions.js index 98612c2..731a631 100644 --- a/js/versions.js +++ b/js/versions.js @@ -1,11 +1,18 @@ export const versions = { - "version": "0.34.0f", - "releaseDate": "2024-11-4", + "version": "0.34.0g", + "releaseDate": "2024-11-5", "name": "ComfyUI-Griptape", "description": "Griptape integration for ComfyUI", "author": "Jason Schleifer", "repository": "https://github.com/griptape-ai/ComfyUI-Griptape", "changelog": [ + { + "version": "0.34.0g", + "date": "2024-11-5", + "changes": [ + "Fixed issue with `dynamicprompt` inputs", + ] + }, { "version": "0.34.0f", "date": "2024-11-4", diff --git a/pyproject.toml b/pyproject.toml index f33cc29..3559432 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "comfyui-griptape" -version = "1.0.17" +version = "1.0.18" description = "Griptape LLM(Large Language Model) Nodes for ComfyUI." authors = ["Jason Schleifer "] readme = "README.md" @@ -26,7 +26,7 @@ priority = "explicit" [project] name = "comfyui-griptape" description = "Griptape LLM(Large Language Model) Nodes for ComfyUI." -version = "1.0.17" +version = "1.0.18" license = {file = "LICENSE"} dependencies = ["griptape[all]==0.34.0", "python-dotenv"] From ba367ff134d4644b597e591c7f32c5643228d82e Mon Sep 17 00:00:00 2001 From: Jason Schleifer Date: Tue, 5 Nov 2024 07:25:09 +1300 Subject: [PATCH 4/4] remove dynamic prompt --- nodes/agent/gtUIRunAgent.py | 2 +- nodes/rag/gtUITextLoaderRetrievalRagModule.py | 2 +- nodes/text/gtUIInputStringNode.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nodes/agent/gtUIRunAgent.py b/nodes/agent/gtUIRunAgent.py index f3cef59..9db0ec2 100644 --- a/nodes/agent/gtUIRunAgent.py +++ b/nodes/agent/gtUIRunAgent.py @@ -50,7 +50,7 @@ def INPUT_TYPES(s): "inputs": ("*",), "text": ( "STRING", - {"multiline": True, "dynamicPrompts": True}, + {"multiline": True, "dynamicPrompts": False}, ), }, } diff --git a/nodes/rag/gtUITextLoaderRetrievalRagModule.py b/nodes/rag/gtUITextLoaderRetrievalRagModule.py index e32d051..9351d2e 100644 --- a/nodes/rag/gtUITextLoaderRetrievalRagModule.py +++ b/nodes/rag/gtUITextLoaderRetrievalRagModule.py @@ -31,7 +31,7 @@ def INPUT_TYPES(s): "STRING", { "forceInput": True, - "dynamicPrompts": True, + "dynamicPrompts": False, "tooltip": "Text to be loaded.", }, ), diff --git a/nodes/text/gtUIInputStringNode.py b/nodes/text/gtUIInputStringNode.py index aad4fed..e331358 100644 --- a/nodes/text/gtUIInputStringNode.py +++ b/nodes/text/gtUIInputStringNode.py @@ -18,7 +18,7 @@ def INPUT_TYPES(s): return { "required": {}, "optional": { - "STRING": ("STRING", {"multiline": True, "dynamicPrompts": True}) + "STRING": ("STRING", {"multiline": True, "dynamicPrompts": False}) }, }