remove jQuery and chroma-hash.js from plans login screen #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsole errors and ~120kb (gzipped) JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot about the chroma-hash feature that the login screen password's input used to have until I saw these console errors:
and then
and then
It appears that
chroma-hash.jsis the only reason for jQuery on the login screen at all so if we remove both we get rid of 119.15KB of JS (gzipped) on the home screen and the console errors.I looked for other jQuery and chroma-hash references throughout the codebase and didn't find any. Also, they are all grouped together in
index.php, further suggesting they were added all together. So I think this is a pretty safe change. If the form was working with the errors, I expect it will continue working without them.Closes #301