Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery from home page #301

Open
mrwweb opened this issue Oct 27, 2024 · 2 comments · May be fixed by #303
Open

Remove jQuery from home page #301

mrwweb opened this issue Oct 27, 2024 · 2 comments · May be fixed by #303

Comments

@mrwweb
Copy link
Contributor

mrwweb commented Oct 27, 2024

I'm currently seeing 3 console errors on the homepage (index.php) in Firefox and Chrome. It appears that this is because Googles JS loader used to load jQuery 1.3.2 (😱) is deprecated.

I believe the only purpose for jQuery on the home page in the first place was the password "chromahash" function. Given that this hasn't been working for quite some time (I think), I'd propose we completely strip jQuery off the home page and drop the chromahash function.

Any objections? Happy to submit the PR.

@acohn
Copy link
Contributor

acohn commented Oct 27, 2024

Sounds good to me!

@mrwweb
Copy link
Contributor Author

mrwweb commented Oct 28, 2024

Sounds good. I'll get that done sometime soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants