-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve icons and add manifest to improve installing/mobile experience #299
Comments
This all sounds like good stuff, and like it's unlikely to cause problems with anything else and therefore shouldn't require much regression testing. 👍 from me. |
After double-posting this issue (doik, my bad), here are some proposed values and a few questions:
Notes:
|
I just searched and I also don't seem to have a source for the logo. I swear I've seen or heard of one, though. Maybe @ianatha knows? Those proposed values look good to me and in general I trust your judgement when it comes to answering questions like (3). |
@iangreenleaf Appreciate the trust :) I'm curious, do you think a |
I think I lean towards yes too. We're far enough from being app-like that I think it probably is wise to maintain some amount of web chrome. But of course, it mostly depends how that plays out in practice... |
With trends toward Progressive Web Apps, new support for installing websites in MacOS/iOS, etc. it strikes me as a good idea to add/update the following things to Plans:
site.webmanifest
file that definesname
(Grinnell Plans),short_name
(Plans),start_url
(https://grinnellplans.com/home.php), and probably thedisplay
type (standalone?). I don't think defining atheme_color
orbackground_color
makes sense as that seems likely to clash with most stylesheets and light/dark preferencesOver time, this would improve the experience for people "installing" plans on their home screens/task bars/etc.
I can't think of a downside, but I am very curious if people can think of extra considerations or potential downsides. I'm happy to submit the PR if at least a couple people think it's worth doing.
The text was updated successfully, but these errors were encountered: