Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-14 Support #7

Open
wandersonwhcr opened this issue Apr 26, 2021 · 1 comment
Open

PSR-14 Support #7

wandersonwhcr opened this issue Apr 26, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v1.1 Athena

Comments

@wandersonwhcr
Copy link
Member

Griffin has a direct dependency to psr/event-dispatcher.

But we really need it? Can we run Griffin without PSR-14 installs even using Griffin\Event\DispatcherAwareTrait?

How to test it?

If it works, change docs.

Also, suggests PSR-14 via Composer.
@wandersonwhcr wandersonwhcr added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 26, 2021
@wandersonwhcr wandersonwhcr added this to the v1.1 Athena milestone Apr 26, 2021
@wandersonwhcr
Copy link
Member Author

I think we can't remove PSR-14 requirement because Griffin\Runner\Runner::up and Griffin\Runner\Runner::down methods use Griffin\Runner\Runner::getEventDispatcher internally and it was defined with a typed return.

But we must check it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v1.1 Athena
Development

No branches or pull requests
1 participant
@wandersonwhcr