Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making FGMRESSolver accept nothing as the right preconditioner #85

Closed
shreyas02 opened this issue Dec 17, 2024 · 3 comments
Closed

Making FGMRESSolver accept nothing as the right preconditioner #85

shreyas02 opened this issue Dec 17, 2024 · 3 comments

Comments

@shreyas02
Copy link

I am working on a project where I only want to use the left preconditioner using the FGMRES solver. I want this solver to accept nothing as the input for the right preconditioner. Can I create a pull request with these changes?

@JordiManyer
Copy link
Member

Hi @shreyas02 , I believe FGMRES is not flexible wrt the left preconditioner. I follow the article from Saad, but if you look around (for instance PETSc) you will see no-one has a left-preconditioned FGMRES.

At least that is my understanding. Can you provide any reference implementing/showcasing a left-preconditioned flexible FGMRES? If you do, I'll be glad to accept your PR.

Alternatively, you can use GMRES with only a left-preconditioner. But the preconditioner needs to be static.
Let me know what you think.

@shreyas02
Copy link
Author

Hi @JordiManyer, You seem to be correct. I should be using the GMRES solver, at least for now. Thank you!

@JordiManyer
Copy link
Member

@shreyas02 No worries! Thanks for using the library, and for being willing to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants