-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper #74
Comments
I will address your semantic/grammar related comments.
I agree, it is not the most standard terminology. We are basically addressing the same smoothers described here.
In this sentence, Maybe we could rephrase it as: """ |
Patch based: maybe you could just add that explanation of what those patches are (essentially what you are saying above)? The blocked system: maybe one could refer to solves with coefficient matrices (a) mass matrix and (b) solve with a velocity matrix, the first one with CG+Jacobi, the second with GMG? |
I've hopefully addressed everything. You can find the new compiled version of the pdf here. Let me know if there is anything that needs to be looked at. |
Hello, I have some points about your paper:
(I think it is okay, just double check to make sure you have not missed any DOIs)
|
Those skipped dois are all repos/codes. I tried to find dois for them, but to my best knowledge there is none. |
That sounds good (I actually assumed so, I just wanted to make sure you haven't missed anything) |
Line 21: uniquely -- is it used to indicate "solely"?
Line 70: patch-based -- not sure what it means. It does not appear to be "standard" terminology.
Line 82, 83: Shur -> Schur
Line 84: it's spectral -> its spectral
Line 88: The mass matrix is approximated by a Conjugate Gradient (CG) solver with... This sentence needs some work. I am not sure what you mean.
Line 91: it is setup -> it is set up
Line 128 - 131: h(div) -> H(div), h(curl) -> H(curl)
The text was updated successfully, but these errors were encountered: