Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail #73

Closed
PetrKryslUCSD opened this issue Sep 23, 2024 · 8 comments
Closed

Tests fail #73

PetrKryslUCSD opened this issue Sep 23, 2024 · 8 comments

Comments

@PetrKryslUCSD
Copy link

https://gist.github.com/PetrKryslUCSD/284fbe5235809039b8ad3581f0059f55

@JordiManyer
Copy link
Member

My first comment would be why are you testing GridapPETSc.jl, instead of GridapSolvers.jl?

Otherwise, the error seems to be related to MPI.

  • Where are you running your tests? Are you using custom binaries, or artifacts?
  • When using MPI you have to build your project, not only instantiate. Most weird errors go away after building, which is crucial to link all the binaries together.

@PetrKryslUCSD
Copy link
Author

You are right, I did start by testing GridapSolvers, but the errors below seemed to implicate GridapPETSc. I may be wrong, of course.
This is from the failed test of GridapSolvers:
https://gist.github.com/PetrKryslUCSD/3114a3e5e0a64adc2ba53f14a6c204ca

@PetrKryslUCSD
Copy link
Author

You are right, I did start by testing GridapSolvers, but the errors below seemed to implicate GridapPETSc. I may be wrong, of course.
This is from the test of
https://gist.github.com/PetrKryslUCSD/3114a3e5e0a64adc2ba53f14a6c204ca

@JordiManyer
Copy link
Member

JordiManyer commented Sep 24, 2024

It's an MPI issue, I think. The serial tests are running fine on both cases, but it fails to load the environment when doing the MPI tests.
Try building the packages first, then run the tests. Instantiating is not enough. I.e

using Pkg
Pkg.build()

If you follow the README.md, everything is there.

@PetrKryslUCSD
Copy link
Author

I did what the README suggested. Activ/inst + build.

@JordiManyer
Copy link
Member

JordiManyer commented Sep 24, 2024

I think MPI.jl might have disabled some mpiexec flags we were using (namely --allow-run-as-root), I've pushed a couple changes to main.

Could you please try this:

using Pkg
Pkg.add(;name="GridapSolvers",rev="main");
Pkg.build()

then exit and re-start julia, which allows the links created by build to take effect. I think this was what was causing the issue on your end. If you don't restart, the changes don't take effect. Once this is done, try testing it.

I just tested this on our linux cluster, and it seems to run.

@PetrKryslUCSD
Copy link
Author

Fantastic, all tests pass.

@JordiManyer
Copy link
Member

Great, I'll do a new minor release and modify our README to make all of this more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants