Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing numerical_setup! for IterativeLinearSolverNS #60

Open
oriolcg opened this issue May 19, 2024 · 1 comment
Open

missing numerical_setup! for IterativeLinearSolverNS #60

oriolcg opened this issue May 19, 2024 · 1 comment

Comments

@oriolcg
Copy link
Member

oriolcg commented May 19, 2024

Hi @JordiManyer , I think the implementation of the function numerical_setup! is missing for IterativeLinearSolverNS. When solving a transient problem using an iterative solver, this function is called here: https://github.com/gridap/Gridap.jl/blob/9079dd1ac56da9ca5f6d8d3952d69caa6c014fa4/src/ODEs/StageOperators.jl#L280

I tried to have a look at what is the problem and how to solve it, but since this is a wrapper of many solvers, before implementing anything I would like to ask if this is indeed missing or am I doing something wrong. Could you take a look at it?

Thank you!

@JordiManyer
Copy link
Member

Hi @oriolcg , I think it's just missing. I've probably never needed it before. Feel free to do a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants