Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling residual! instead of jacobian! #54

Open
oriolcg opened this issue Apr 8, 2024 · 1 comment
Open

Calling residual! instead of jacobian! #54

oriolcg opened this issue Apr 8, 2024 · 1 comment

Comments

@oriolcg
Copy link
Member

oriolcg commented Apr 8, 2024

Hi @JordiManyer, I was doing some code profiling (an issue to be reported/addressed in Gridap) and I found this possible error:

GridapSolvers.jl/src/BlockSolvers/BlockFEOperators.jl

Line 64 in 26aa6f9

residual!(A,op,u)

I think here it should be calling jacobian! instead of residual!, right?
@JordiManyer
Copy link
Member

Hi @oriolcg , The BlockFEOperators are halfway-implemented. I need to re-define the API and add functionalities that I want to have. I am currently tied into other things, I'll probably leave this for version 0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oriolcg @JordiManyer