Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Secure Token option [#85] #104

Closed
wants to merge 9 commits into from

Conversation

umbertix
Copy link

I've added a new option with backwards compatibility to use the Secure token option, as described here https://developers.google.com/recaptcha/docs/secure_token, in order to use it you have to add a data-stoken field.

Also updated the readme file in order to explain the new option and an example of the use.

Please feel free to edit, comment or let me know any change that you might feel necessary in order to merge.

Please note that as in the Issue [#85] @danieljausovec has helped me and provided a first draft of the code.

@danieljausovec
Copy link

Nice. Well done!
I am glad that I could help in this project.

@greggilbert
Copy link
Owner

Couple of thoughts on this:

  • In the config, can you make it called secureToken rather than sToken? A bit more clarity.
  • Squash the commits, please?
  • See my inline comments above.

Umbert Pensato added 2 commits March 15, 2016 17:46
Refactor, renamed the Stoken references to a less cryptic name secure_token or useSecureToken
Ammends on the readme file to follow the new naming.
Version change reverted.
# Conflicts:
#	src/Recaptcha.php
@umbertix umbertix closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants