Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new optional fields API #16

Open
vmarcosp opened this issue Dec 22, 2022 · 4 comments
Open

Add support for the new optional fields API #16

vmarcosp opened this issue Dec 22, 2022 · 4 comments

Comments

@vmarcosp
Copy link
Contributor

vmarcosp commented Dec 22, 2022

Hey team!
First off, thanks for your awesome work and contributions to the rescript ecosystem ❤️

I'm using this ppx to build the new version of Ancestor and one ppx that could save me a lot of work is partial. However, partial doesn't support the new optional fields api introduced on the rescript @ v10.
Are you planning to add support for the new optional fields api? If so, can I help you with this feature?

@mununki
Copy link
Member

mununki commented Dec 22, 2022

@vmarcosp Hey!
Thank you for using this ppx.
Sure, it would support the optional field record. I couldn't grab the time to fix it yet. PR is always welcome! 👍

@vmarcosp
Copy link
Contributor Author

Nice!
Sure, I can help with this issue :)
Are you planning to keep supporting both apis using ?: and option or should we create a second partial implementation?

@mununki
Copy link
Member

mununki commented Dec 22, 2022

Good question!
I think the partial ppx should support the ? not option<'a> which is now possible with the new feature of v10. I prefer not to make a breaking change, but this time breaking would be okay.
What do you think?

@vmarcosp
Copy link
Contributor Author

I agree, it's ok to me make a breaking since ppl can still using the current version instead of migrating to a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants