Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% string duplication prevents using PARSE_DATE() SQL function #10397

Open
strunov opened this issue Sep 16, 2024 · 2 comments
Open

% string duplication prevents using PARSE_DATE() SQL function #10397

strunov opened this issue Sep 16, 2024 · 2 comments
Labels
bug Bugs bugs bugs! fix-in-prog

Comments

@strunov
Copy link

strunov commented Sep 16, 2024

Describe the bug

If I use a SQL data asset or a SQL unexpected rows expectation using % format
then the query gets changed - the % gets duplicated.

Escaping the query with \% produces \%% query string.

To Reproduce
Please include your great_expectations.yml config, the code you’re executing that causes the issue, and the full stack trace of any error(s).

  • I'm using an ephemeral context
  • there is no runtime error
  • the error is at database engine level
  • query gets mangled

Expected behavior
Raw queries should be treated as is IMO

Environment (please complete the following information):

  • Operating System: windows
  • Great Expectations Version: 1.0.2
  • Data Source: BigQuery
  • Cloud environment: local

Additional context
Add any other context about the problem here.

@adeola-ak
Copy link
Contributor

hi @strunov, thanks for bringing this to our attention. I've shared it with the team and will follow up soon!

@adeola-ak adeola-ak moved this from To Do to In Progress in GX Core Issues Board Sep 16, 2024
@adeola-ak adeola-ak added the bug Bugs bugs bugs! label Sep 17, 2024
@cdkini
Copy link
Member

cdkini commented Sep 18, 2024

@strunov could you please provide an example of a query that happens to cause this issue? Additionally, where is it that you're actually seeing the mangled query? In the result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs bugs bugs! fix-in-prog
Projects
Status: Fixing
Development

No branches or pull requests

3 participants