Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why has EmailAction / EmailRenderer deactivated sending the data docs link? #10324

Open
MarcelBeining opened this issue Sep 2, 2024 · 5 comments · May be fixed by #10408
Open

Why has EmailAction / EmailRenderer deactivated sending the data docs link? #10324

MarcelBeining opened this issue Sep 2, 2024 · 5 comments · May be fixed by #10408
Labels
feature-request feature request

Comments

@MarcelBeining
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Previously, it was possible to add data doc links to the sent email, such that on validation failures, people could directly go to the corresponding data doc site.
Now, this seems to have been removed, even though the EmailRenderer still has an unused method _get_report_element for this and other Actions/Renderers like the MicrosoftTeamsNotificationAction nicely get the corresponding link from the action_context and render it.

Describe the solution you'd like
The Email Action / Renderer should support this, too and it should be really straightforward to implement this there like it is in MicrosoftTeams Action/Renderer, too.
I would even do a PR for it, provided there was no higher level decision or whatever, why this has been removed (?).

@adeola-ak adeola-ak added the feature-request feature request label Sep 4, 2024
@adeola-ak
Copy link
Contributor

Hi @MarcelBeining, while I investigate the reason behind this change in behavior, I encourage you to submit a PR if you're interested. We're always happy to accept contributions. You can find some guidance on how to do this here.

@MarcelBeining
Copy link
Contributor Author

We're on it, my colleague will send a PR soon

@Pascal06S Pascal06S linked a pull request Sep 17, 2024 that will close this issue
4 tasks
@MarcelBeining
Copy link
Contributor Author

@adeola-ak can someone accept the PR linked here?

@MarcelBeining
Copy link
Contributor Author

@adeola-ak Still waiting for the PR to be accepted

@adeola-ak
Copy link
Contributor

hi @MarcelBeining, I apologize for the delayed response—I’m not sure how I missed this notification! My colleague just brought it to my attention, and he's reviewing the PR now. I’m really sorry for the oversight; I’ve since updated my settings to prevent this from happening again. Thank you so much for your contribution, and again, my apologies for the delay.

@adeola-ak adeola-ak linked a pull request Oct 30, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

2 participants