-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why has EmailAction / EmailRenderer deactivated sending the data docs link? #10324
Comments
Hi @MarcelBeining, while I investigate the reason behind this change in behavior, I encourage you to submit a PR if you're interested. We're always happy to accept contributions. You can find some guidance on how to do this here. |
We're on it, my colleague will send a PR soon |
@adeola-ak can someone accept the PR linked here? |
@adeola-ak Still waiting for the PR to be accepted |
hi @MarcelBeining, I apologize for the delayed response—I’m not sure how I missed this notification! My colleague just brought it to my attention, and he's reviewing the PR now. I’m really sorry for the oversight; I’ve since updated my settings to prevent this from happening again. Thank you so much for your contribution, and again, my apologies for the delay. |
Is your feature request related to a problem? Please describe.
Previously, it was possible to add data doc links to the sent email, such that on validation failures, people could directly go to the corresponding data doc site.
Now, this seems to have been removed, even though the EmailRenderer still has an unused method
_get_report_element
for this and other Actions/Renderers like theMicrosoftTeamsNotificationAction
nicely get the corresponding link from theaction_context
and render it.Describe the solution you'd like
The Email Action / Renderer should support this, too and it should be really straightforward to implement this there like it is in MicrosoftTeams Action/Renderer, too.
I would even do a PR for it, provided there was no higher level decision or whatever, why this has been removed (?).
The text was updated successfully, but these errors were encountered: