Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_column_pair_values_a_to_be_greater_than_b fail to show unexpected rows #10323

Open
VytSep opened this issue Sep 2, 2024 · 14 comments
Open
Labels
feature-request feature request

Comments

@VytSep
Copy link

VytSep commented Sep 2, 2024

Describe the bug
The expectation expect_column_pair_values_a_to_be_greater_than_b is not generating the unexpected rows

To Reproduce
The expectation is configured this way:
COMPLETE={"result_format": "COMPLETE", "include_unexpected_rows": True}
expectation = gx.expectations.ExpectColumnPairValuesAToBeGreaterThanB(
column_A="date_a",
column_B="date_b",
or_equal=True,
result_format=COMPLETE,
)

The checkpoint is configured this way:
checkpoint_name = "my_checkpoint"
checkpoint = gx.Checkpoint(
name=checkpoint_name,
validation_definitions=validation_definitions,
result_format={"result_format": "COMPLETE", "include_unexpected_rows": True},
)

Expected behavior
Have in the validation result the unexpected rows for this expectation

Environment (please complete the following information):

  • Great Expectations Version: [1.0.0]
  • Cloud environment: [Databricks]

Additional context
For other expectations like expect_column_values_to_be_in_set I do have the unexpected rows generated

@adeola-ak
Copy link
Contributor

hi there - just want to let you know i am looking into this. to my knowledge, both should be returning unexpected rows. Please stand by while I continue to investigate

@adeola-ak
Copy link
Contributor

adeola-ak commented Sep 5, 2024

following up here, what are you getting it back? do you see the key returning the object for unexpected rows like you do for expect_column_values_to_be_in_set at all?

@VytSep
Copy link
Author

VytSep commented Sep 9, 2024

I do have key returning for the expect_column_values_to_be_in_set and also for the expect_column_pair_values_a_to_be_greater_than_b

@adeola-ak
Copy link
Contributor

so you have the unexpected values key being returned for both but for expect_column_pair_values_a_to_be_greater_than_b the key is just empty? can you share a ss?

@adeola-ak adeola-ak moved this from To Do to In Progress in GX Core Issues Board Sep 9, 2024
@VytSep
Copy link
Author

VytSep commented Sep 10, 2024

Yes, I do have the keys for both expectations. What do you mean for ss?

@adeola-ak
Copy link
Contributor

screenshot i'm sorry

@VytSep
Copy link
Author

VytSep commented Sep 10, 2024

Sorry, I don't have permission to share screenshots

@adeola-ak
Copy link
Contributor

adeola-ak commented Sep 10, 2024

understood no problem! but again, is the unexpected_rows key empty or returning null or something else?

if you edit your project to only have the expect_column_pair_values_a_to_be_greater_than_b expectation, and run print(validation_results["results"][0]["result"]["unexpected_rows"]) what do you see? As i'm seeing None across a few projects, I do need to clarify again what is expected with such an expecation that is evaluated for a pair of columns. I will get a concrete answer to you by today

@VytSep
Copy link
Author

VytSep commented Sep 19, 2024

Screenshot 2024-09-19 120452

@VytSep
Copy link
Author

VytSep commented Sep 23, 2024

Hi team, any news on that subject?

@adeola-ak adeola-ak added the bug Bugs bugs bugs! label Oct 1, 2024
@adeola-ak
Copy link
Contributor

Hi @VytSep, thank you for your patience. This issue has been confirmed as a bug. Unfortunately, I don't have a specific timeline for when it will be addressed, but I plan to follow up with the team tomorrow and should have an update then.

@adeola-ak
Copy link
Contributor

@VytSep did this work for you in the past? or prior to 1.0?

@VytSep
Copy link
Author

VytSep commented Oct 9, 2024

Hi @adeola-ak , no i did not. I have the same issue also with the 0.18.15 version.

@adeola-ak
Copy link
Contributor

hi @VytSep sorry that I misspoke earlier this month. After further review, though unexpected rows works for ColumnMapExpectations, this behavior is expected for all ColumnPairMapExpectations. I will update our documentation to reflect this. For now, having this functionality would be considered a feature request, which is not prioritized at the moment. Thank you for your patience, and I apologize if this isn't the outcome you were hoping for.

@adeola-ak adeola-ak added the feature-request feature request label Oct 22, 2024
@adeola-ak adeola-ak moved this from In progress to To Do in GX Core Issues Board Oct 22, 2024
@adeola-ak adeola-ak removed the bug Bugs bugs bugs! label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
Status: To Do
Development

No branches or pull requests

2 participants