[FEATURE] Adds the ability to add Externald and Tags to boto3_options of TupleS3StoreBackend #10075
Conversation
…sume-role call for greater flexibility in using cross-account roles.
…sume-role call for greater flexibility in using cross-account roles.
…ature/aws_external_id # Conflicts: # great_expectations/data_context/store/tuple_store_backend.py # tests/data_context/store/test_store_backends.py
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: rosspb3 |
|
@cla-bot check |
|
Hello @rosspb3. With the launch of Great Expectations Core (GX 1.0), we are closing old PRs posted regarding previous versions. Moving forward, we will focus our resources on supporting and improving GX Core (version 1.0 and beyond). If you find that an issue or PR you previously reported still exists in GX Core, we encourage you to resubmit it against the new version. With more resources dedicated to community support, we aim to tackle new issues swiftly. For specific details on what is GX-supported vs community-supported, you can reference our integration and support policy. To get started on your transition to GX Core, check out the GX Core quickstart (click “Full example code” tab to see a code example). Thank you for being part of the GX community and thank you for submitting this issue. We're excited about this new chapter and look forward to your feedback on GX Core. 🤗 |
|
Hello @molliemarie, I did create a new feature request and updated the PR with the issue number and the latest code from the develop branch as the issue still exists with the latest code. |
boto3_options of TupleS3StoreBackend now supports external_id and tags which gets passed to the sts assume_role call as ExternalId and Tags. This will support greater cross-account role policy scenarios.
Resolves #10272
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!