Secrets, never expiring @lru_cache
and AWS Secrets Rotation
#6042
KentonParton
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was looking at the GE secrets implementation and noticed that the
@lru_cache
hasmaxsize
set toNone
.great_expectations/great_expectations/data_context/util.py
Lines 237 to 238 in 4b0276e
While I haven't tested this, I foresee the infinite cache being an issue for AWS Secrets Manager secrets rotation. As the name suggests, AWS rotates your secret every N days or via a lambda function. With that in mind, should
@lru_cache
be set to expire every 24 hours?Beta Was this translation helpful? Give feedback.
All reactions