Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleport charts don't play well with ArgoCD #49353

Open
hugoShaka opened this issue Nov 22, 2024 · 1 comment
Open

Teleport charts don't play well with ArgoCD #49353

hugoShaka opened this issue Nov 22, 2024 · 1 comment

Comments

@hugoShaka
Copy link
Contributor

hugoShaka commented Nov 22, 2024

ArgoCD does not implement Helm hooks properly. We got bit several times by this.
The last occurrence was today when a customer's ArgoCD instance deployed the cleanup hook which caused

Workaround:

  • add a value to disable every hook in each chart values: this might be usefulful for people using kustomize or helm template

Short term:

  • test manually our chart agianst ArgoCD (both latest, and <2.10 as post delete hook implem is different)
  • experiment to see if we can detect argo and disable hooks
  • experiment and document which argo version deploy which hooks
  • add argo hook annotations to our hook resources to either skip them, or have argo do proper thing instead of random harmful stuff
  • document this Helm hook horror story somewhere in the charts README so if we were to add new hooks, we know what to do

Mid term:

  • create ArgoCD testing instructions (in the Makefile? test plan?)

Long term:

  • setup an ArgoCD soaking cluster to detect those issues before users hit them?
@milos-teleport
Copy link
Contributor

Related: #48905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants