Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources cards/rows - Button widths are inconsistent w/designs and unnecessarily wide in card view #49295

Open
roraback opened this issue Nov 20, 2024 · 0 comments
Labels

Comments

@roraback
Copy link
Contributor

roraback commented Nov 20, 2024

Expected behavior:

In card view, buttons should have 2 sizes to take up as little horizontal space as necessary, in order to optimize for longer resource names. Connect, Launch, and Log-In buttons should be ~84px wide and "+ Request Access"/Request Role buttons should be ~124px wide. In table view, buttons should have uniform width so that they all align.

Also expected: Request Access buttons should be filled neutral buttons (no border, with level 0 spot background) to make it clearer that they are going to do something different from the Connect/Launch/Log In buttons.

Screenshot of design:
Image

Current behavior:

Buttons currently always all have the width of the biggest button, "+ Request Access", except for segmented “Log In”/“…” buttons, which are overall ~24px wider than other buttons.

Screenshot from Teleport 17 in card mode. Note the unnecessarily wide buttons:
Image

Screenshot from Teleport 17 in table mode with uniform buttons except the "Log In" segmented button:
Image

Bug details:

  • Teleport version: observed in 17.0.1 and 16.4.7, but it slipped past my notice for a while - it isn't new.
  • Recreation steps: Go to resources view and look at button sizes in card view
@roraback roraback changed the title Resources cards/rows - Button widths are inconsistent with designs Resources cards/rows - Button widths are inconsistent and unnecessarily wide in card view Nov 20, 2024
@roraback roraback changed the title Resources cards/rows - Button widths are inconsistent and unnecessarily wide in card view Resources cards/rows - Button widths are inconsistent w/designs and unnecessarily wide in card view Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant