Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

sort out implications of holdover on 1.0 balances #3551

Closed
chadwhitacre opened this issue Jun 12, 2015 · 3 comments
Closed

sort out implications of holdover on 1.0 balances #3551

chadwhitacre opened this issue Jun 12, 2015 · 3 comments

Comments

@chadwhitacre
Copy link
Contributor

When paying out, we withhold money equal to participants.giving in order to cover next week's tips. This leads to unexpected behavior when cashing out 1.0 balances (#3481). Are we ready to drop holdovers (#3475)?

@chadwhitacre
Copy link
Contributor Author

I believe someone in the pending-payout state will stay there indefinitely until their balance reaches zero.

@rohitpaulk
Copy link
Contributor

Are we ready to drop holdovers (#3475)?

Is that what's required here? The problem here is the check for updating the pending-payout state - it should be 'has been paid out once', rather than 'has a balance of zero'.

@chadwhitacre
Copy link
Contributor Author

Holdovers are gone in #3629.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants