Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require network for approving queued actions #780

Closed
7 tasks done
alex-pakalniskis opened this issue Sep 18, 2023 · 1 comment · Fixed by #783
Closed
7 tasks done

Require network for approving queued actions #780

alex-pakalniskis opened this issue Sep 18, 2023 · 1 comment · Fixed by #783
Labels
enhancement New feature or request indexer-cli p1
Milestone

Comments

@alex-pakalniskis
Copy link
Contributor

alex-pakalniskis commented Sep 18, 2023

"On Friday I found an issue with the multi-network indexer-cli that is a bit scary to me. The indexer actions approve queued command doesn't require or even accept a network parameter, so it will approve all queued actions across all protocolNetworks. We need to update this to require network."
-Ford

Requirements

Preview Give feedback

Acceptance criteria

Preview Give feedback
@alex-pakalniskis alex-pakalniskis converted this from a draft issue Sep 18, 2023
@tilacog tilacog moved this from 🗃️ Inbox to 🏗️ In Progress in Indexer Sep 19, 2023
@tilacog
Copy link
Contributor

tilacog commented Sep 19, 2023

No argument asks for a protocolNetwork in the actions approve command, as it expects either the action ID or the "queued" identifiers.

@tilacog tilacog linked a pull request Sep 19, 2023 that will close this issue
@tilacog tilacog moved this from 🏗️ In Progress to 🚩 In Review in Indexer Sep 20, 2023
@tilacog tilacog modified the milestone: v0.20.23 Sep 20, 2023
@github-project-automation github-project-automation bot moved this from 🚩 In Review to ❌ Closed in Indexer Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request indexer-cli p1
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants